Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forcerescan #2824

Closed
wants to merge 1 commit into from
Closed

Add forcerescan #2824

wants to merge 1 commit into from

Conversation

daedalus
Copy link

I have found this usefull when I have to import keys with pywallet for example.

@gmaxwell
Copy link
Contributor

Hm. Does pywallet not correctly handle the height records? If its adding a key to a wallet it should zero it out.

@sipa
Copy link
Member

sipa commented Jul 12, 2013

I suppose it does not, but even then - there shouldn't ever be a need to rescan except when loading a wallet, so this should be done via the command-line (-reindex) instead of via RPC?

Or is there a reason why an RPC is preferrable?

@sipa sipa closed this Jul 12, 2013
@sipa sipa reopened this Jul 12, 2013
@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/965e091ef117c82e42e763114f747dfd7e76e749 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@yhaenggi
Copy link

yhaenggi commented Aug 7, 2013

@sipa its only usefull if you forgot to run with -rescan so you dont have to stop + start again, anyone editing the wallet while bitcoind is running is stupid. id say this new RPC call would atrract alot of ppl exactly doing this, therefore its not a that good idea.

@wtogami
Copy link
Contributor

wtogami commented Aug 15, 2013

NACK

@gavinandresen
Copy link
Contributor

NACK from me, too. Closing.

Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Apr 5, 2019
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants