Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP 32 derivation + test vectors #2829

Merged
merged 4 commits into from
Aug 15, 2013
Merged

BIP 32 derivation + test vectors #2829

merged 4 commits into from
Aug 15, 2013

Conversation

sipa
Copy link
Member

@sipa sipa commented Jul 14, 2013

This does not add actual deterministic wallet functionality yet, only an implementation of BIP32 derivation and its test vectors.

I'm usually not in favor of adding code that isn't used yet, but in this case it may be useful to give a "reference implementation" exposure.

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a59db19ee3b454680b3bb0aa881e601b9311a9ae for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@simondlr
Copy link
Contributor

Do you plan on eventually implementing full BIP 32 support into Bitcoin-QT?

@sipa
Copy link
Member Author

sipa commented Jul 27, 2013

@simondlr Of course.

@simondlr
Copy link
Contributor

@sipa Awesome! Looking forward to it.

@sipa
Copy link
Member Author

sipa commented Aug 15, 2013

@gavinandresen @jgarzik @gmaxwell Opinions?

@gmaxwell
Copy link
Contributor

ACK. On the basis that this has already been used to validate other implementations and has even turned up some bugs, I think it would be good to include this.

@jgarzik
Copy link
Contributor

jgarzik commented Aug 15, 2013

ACK

gavinandresen added a commit that referenced this pull request Aug 15, 2013
BIP 32 derivation + test vectors
@gavinandresen gavinandresen merged commit 13d3b1c into bitcoin:master Aug 15, 2013
Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Apr 5, 2019
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants