-
Notifications
You must be signed in to change notification settings - Fork 35.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIP 32 derivation + test vectors #2829
Conversation
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a59db19ee3b454680b3bb0aa881e601b9311a9ae for binaries and test log. |
Do you plan on eventually implementing full BIP 32 support into Bitcoin-QT? |
@simondlr Of course. |
@sipa Awesome! Looking forward to it. |
@gavinandresen @jgarzik @gmaxwell Opinions? |
ACK. On the basis that this has already been used to validate other implementations and has even turned up some bugs, I think it would be good to include this. |
ACK |
BIP 32 derivation + test vectors
This does not add actual deterministic wallet functionality yet, only an implementation of BIP32 derivation and its test vectors.
I'm usually not in favor of adding code that isn't used yet, but in this case it may be useful to give a "reference implementation" exposure.