Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: restrict abis in bitcoind.service #28340

Merged
merged 1 commit into from Apr 17, 2024

Conversation

CharlieC3
Copy link
Contributor

@CharlieC3 CharlieC3 commented Aug 24, 2023

As noted here, it's a good idea to pair MemoryDenyWriteExecute=true with SystemCallArchitectures=native because MemoryDenyWriteExecute can be circumvented in some operating systems which support multiple ABIs like x86/x86-64.
This helps restrict the possible application binary interfaces (ABIs) that can be used when running bitcoind through systemd, reducing the attack surface area.

It's recommended to restrict the possible application binary interfaces that can be used when setting `MemoryDenyWriteExecute=true` to ensure it cannot be circumvented.
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 24, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK laanwj, 0xB10C
Concept ACK Sjors

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@Sjors
Copy link
Member

Sjors commented Aug 25, 2023

Probably Concept ACK, because nix-bitcoin does this too: https://github.com/fort-nix/nix-bitcoin/blob/master/pkgs/lib.nix

Might as well consider all the extra stuff they added there.

@laanwj
Copy link
Member

laanwj commented Apr 9, 2024

ACK 0244416 . This is a sensible security feature.
It looks like the documentation of systemd.exec even mentions this pairing.

I do agree with @Sjors, however, that when we're adding systemd hardening options, we might as well look further.

@DrahtBot DrahtBot requested a review from Sjors April 9, 2024 14:45
@0xB10C
Copy link
Contributor

0xB10C commented Apr 10, 2024

ACK 0244416

@ryanofsky ryanofsky merged commit dbd2000 into bitcoin:master Apr 17, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants