refactor: Remove WithParams serialization helper, use SER_PARAMS_OPFUNC #28503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
cc @theuni |
maflcko
force-pushed
the
2309-nuke-with-params-force-opfunc-
branch
from
fac9afe
to
fa544f8
Compare
|
Concept ACK. |
added 2 commits
October 13, 2023 10:30
-BEGIN VERIFY SCRIPT- sed -i 's|WithParams(\([a-zA-Z:._]\+\), |\1(|g' $( git grep -l WithParams ) -END VERIFY SCRIPT-
maflcko
force-pushed
the
2309-nuke-with-params-force-opfunc-
branch
from
fa544f8
to
fa664dc
Compare
ajtowns
reviewed
Oct 30, 2023
maflcko
force-pushed
the
2309-nuke-with-params-force-opfunc-
branch
from
fa664dc
to
9999019
Compare
|
reACK 9999019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every serialization parameter struct already has the
SER_PARAMS_OPFUNC, except for one in the tests.For consistency, and to remove verbose code, convert the test to
SER_PARAMS_OPFUNC, and use it everywhere, then remove theWithParamshelper.