Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: returning "moved" pointers from functions in interfaces.cpp #28743

Conversation

ClaytonNorthey92
Copy link

prior, in interfaces.cpp, we were returning unique_ptrs with implicitly deleted constructors, resulting in compiler errors. now, "move" those unique_ptrs to ensure compilation and avoid this error

this issue is similar to this issue

prior, in interfaces.cpp, we were returning unique_ptrs with implicitly deleted constructors, resulting in compiler errors.  now, "move" those unique_ptrs to ensure compilation and avoid this error
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 27, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@maflcko
Copy link
Member

maflcko commented Oct 27, 2023

Please keep the code changes and discussion in one place

@maflcko maflcko closed this Oct 27, 2023
@fanquake
Copy link
Member

Please respond to the question in your first PR. It's almost certain that you are trying to use a compiler that is no-longer supported.

@ClaytonNorthey92
Copy link
Author

@fanquake @maflcko you're both right, sorry for the confusion, my clang version was too old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants