refactors for subpackage evaluation #28758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
dergoegge
reviewed
Oct 31, 2023
glozow
force-pushed
the
2023-10-26711-refactors
branch
from
f60560b
to
6432d24
Compare
glozow
force-pushed
the
2023-10-26711-refactors
branch
from
6432d24
to
80cd897
Compare
dergoegge
suggested changes
Nov 1, 2023
This allows IsSorted() and IsConsistent() to be used by themselves. IsSorted() with a precomputed set is used so that we don't create this set multiple times.
-BEGIN VERIFY SCRIPT- sed -i 's/CheckPackage(/IsWellFormedPackage(/g' $(git grep -l CheckPackage) -END VERIFY SCRIPT-
…, signal BIP125 Support the creation of a transaction with multiple specified inputs or outputs. Also accept a target feerate and return the fee paid. Also, signal BIP125 by default - a subsequent commit needs to RBF something. Co-authored-by: Andrew Chow <achow101@gmail.com>
Avoid duplicate code. This will be used at the end of every AcceptSubPackage and after PreChecks loop in AcceptPackage.
glozow
force-pushed
the
2023-10-26711-refactors
branch
from
80cd897
to
b5a60ab
Compare
glozow
commented
Nov 1, 2023
ariard
reviewed
Nov 2, 2023
| // This function checks consistency based on inputs, and we can't do that if there are | ||
| // no inputs. Duplicate empty transactions are also not consistent with one another. | ||
| // This doesn't create false negatives, as unconfirmed transactions are not allowed to | ||
| // have no inputs. |
There was a problem hiding this comment.
“as unconfirmed transactions are not allowed to have no inputs at consensus validation (see CheckTransaction)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #27463. It splits off the more trivial changes from #26711 for ease of review, as requested in #26711 (comment).
CheckPackagetoIsPackageWellFormedCreateValidTransactionunit test utility to:CleanupTemporaryCoinsinto its own function to be reused later without duplication