Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix, Change up submitpackage results to return results for all transactions #28848

Merged
merged 3 commits into from Dec 1, 2023
Merged

bugfix, Change up submitpackage results to return results for all transactions #28848

merged 3 commits into from Dec 1, 2023

Commits on Nov 29, 2023

  1. RPC submitpackage: change return format to allow partial errors 

    Behavior prior to this commit allows some transactions to
enter into the local mempool but not be reported to the user
when encountering a PackageValidationResult::PCKG_TX result.

This is further compounded with the fact that any transactions
submitted to the mempool during this call would also not be
relayed to peers, resulting in unexpected behavior.

Fix this by, if encountering a package error, reporting all
wtxids, along with a new error field, and broadcasting every
transaction that was found in the mempool after submission.

Note that this also changes fees and vsize to optional,
which should also remove an issue with other-wtxid cases.
    @instagibbs
    instagibbs committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    b67db52 View commit details
    Browse the repository at this point in the history

  2. doc: submitpackage vsize results are sigops-adjusted

    @instagibbs
    instagibbs committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    e67a345 View commit details
    Browse the repository at this point in the history

  3. test_submitpackage: only make a chain of 3 txns

    @instagibbs
    instagibbs committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f23ba24 View commit details
    Browse the repository at this point in the history