Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: AutoFile with XOR #28873

Merged
merged 3 commits into from
Nov 17, 2023
Merged

fuzz: AutoFile with XOR #28873

merged 3 commits into from
Nov 17, 2023

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Nov 14, 2023

This should help to get fuzz coverage for https://maflcko.github.io/b-c-cov/fuzz.coverage/src/streams.cpp.gcov.html

Also, remove unused code and fix a timeout bug.

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 14, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot changed the title fuzz: AutoFile with XOR fuzz: AutoFile with XOR Nov 14, 2023
@DrahtBot DrahtBot added the Tests label Nov 14, 2023
MarcoFalke added 3 commits November 14, 2023 17:41
The code is clearer without it.

This is also needed for a future commit.
A higher limit is not needed, and only leads to timeouts, see for
example the buffered_file one in
bitcoin#28812 (comment)
@dergoegge
Copy link
Member

Concept ACK

Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fanquake fanquake merged commit afd3e99 into bitcoin:master Nov 17, 2023
16 checks passed
@maflcko maflcko deleted the 2311-fuzz-file- branch November 17, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants