Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: bump libmultiprocess to fix capnproto deprecation warnings #28907

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

ryanofsky
Copy link
Contributor

@ryanofsky ryanofsky commented Nov 17, 2023

This incorporates PR chaincodelabs/libmultiprocess#88 and reverts the NO_WERROR CI workaround added in #28735

Upstream diff: chaincodelabs/libmultiprocess@61d5a0e...414542f


This PR is part of the process separation project.

This incorporates PR chaincodelabs/libmultiprocess#88
"Fix current deprecation warnings as of capnproto-1.0.1" and reverts the
NO_WERROR CI workaround added in bitcoin#28735
@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 17, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@maflcko
Copy link
Member

maflcko commented Nov 19, 2023

lgtm ACK 21bfee0

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 21bfee0, I have reviewed the code and it looks OK. I've also skimmed through the related changes in the https://github.com/chaincodelabs/libmultiprocess repository.

@maflcko maflcko added this to the 27.0 milestone Nov 20, 2023
@fanquake fanquake merged commit a238356 into bitcoin:master Nov 22, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants