-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster size 2 package rbf #28984
Merged
achow101
merged 8 commits into
bitcoin:master
from
instagibbs:2023-12-cluster-size2-package-rbf
Jun 17, 2024
Merged
Cluster size 2 package rbf #28984
achow101
merged 8 commits into
bitcoin:master
from
instagibbs:2023-12-cluster-size2-package-rbf
Jun 17, 2024
+916
−34
Commits on Jun 10, 2024
-
PackageV3Checks: Relax assumptions
Relax assumptions about in-mempool children of in-mempool parents. With package RBF, we will allow a package of size 2 with conflicts on its parent and reconsider the parent if its fee is insufficient on its own. Consider: TxA (in mempool) <- TxB (in mempool) TxA (in mempool) <- TxB' (in package, conflicts with TxB) <- TxC (in package) If TxB' fails to RBF TxB due to insufficient feerate, the package TxB' + TxC will be considered. PackageV3Checks called on TxB' will see an in-mempool parent TxA, and see the in-mempool child TxB. We cannot assume there is no in-mempool sibling, rather detect it and fail normally. Prior to package RBF, this would have failed on the first conflict in package.
Configuration menu - View commit details
-
Copy full SHA for 5da3967 - Browse repository at this point
Copy the full SHA 5da3967View commit details
Commits on Jun 13, 2024
-
Support package RBF where the conflicting package would result in a mempool cluster of size two, and each of its direct conflicts are also part of an up-to-size-2 mempool cluster. This restricted topology allows for exact calculation of miner scores for each side of the equation, reducing the surface area for new pins, or incentive-incompatible replacements. This allows wallets to create simple CPFP packages that can fee bump other simple CPFP packages. This, leveraged with other restrictions such as V3 transactions, can create pin-resistant applications. Future package RBF relaxations can be considered when appropriate. Co-authored-by: glozow <gloriajzhao@gmail.com> Co-authored-by: Greg Sanders <gsanders87@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dc21f61 - Browse repository at this point
Copy the full SHA dc21f61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d15bcf - Browse repository at this point
Copy the full SHA 4d15bcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 316d7b6 - Browse repository at this point
Copy the full SHA 316d7b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3466e4 - Browse repository at this point
Copy the full SHA d3466e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e3c439 - Browse repository at this point
Copy the full SHA 6e3c439View commit details -
Configuration menu - View commit details
-
Copy full SHA for afd52d8 - Browse repository at this point
Copy the full SHA afd52d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94ed4fb - Browse repository at this point
Copy the full SHA 94ed4fbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.