Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: simplify and batch zap wallet txes process #28987

Merged
merged 4 commits into from
Feb 12, 2024

Commits on Jan 6, 2024

  1. wallet: ZapSelectTx, remove db rewrite code

    The function does not return DBErrors::NEED_REWRITE.
    furszy committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    a2b071f View commit details
    Browse the repository at this point in the history
  2. wallet: migration, remove extra NotifyTransactionChanged call

    The wallet is unloaded at the beginning of the migration process,
    so no object is listening to the signals.
    furszy committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    595d50a View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. wallet: batch and simplify ZapSelectTx process

    The goal of the function is to erase the wallet transactions that
    match the inputted hashes. There is no need to traverse the database,
    reading record by record, to then perform single entry removals for
    each of them.
    
    To ensure consistency and improve performance, this change-set removes
    all tx records within a single atomic db batch operation, as well as
    it cleans up code, improves error handling and simplifies the
    transactions removal process entirely.
    
    This optimizes the removal of watch-only transactions during the wallet
    migration process and the 'removeprunedfunds' RPC command.
    furszy committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    83b7628 View commit details
    Browse the repository at this point in the history
  2. scripted-diff: rename ZapSelectTx to RemoveTxs

    -BEGIN VERIFY SCRIPT-
    sed -i 's/ZapSelectTx/RemoveTxs/g' $(git grep -l 'ZapSelectTx' ./src/wallet)
    -END VERIFY SCRIPT-
    furszy committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    9a3c5c8 View commit details
    Browse the repository at this point in the history