Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Improve fuzzing stability for txorphan harness #29031

Merged
merged 1 commit into from Dec 11, 2023

Conversation

dergoegge
Copy link
Member

The txorphan harness has low stability as eviction of orphan txs is entirely random at the moment.

Fix this by passing the rng to LimitOrphans, which can be deterministic in tests.

Also see #29018.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 8, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, brunoerg

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #28970 ([WIP] p2p: opportunistically accept 1-parent-1-child packages by glozow)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@dergoegge dergoegge marked this pull request as ready for review December 8, 2023 13:18
@DrahtBot DrahtBot added the Tests label Dec 8, 2023
@brunoerg
Copy link
Contributor

brunoerg commented Dec 8, 2023

Concept ACK

nice!

@maflcko
Copy link
Member

maflcko commented Dec 8, 2023

lgtm ACK 15f5a0d

Didn't test the stability score.

@dergoegge
Copy link
Member Author

Didn't test the stability score.

I'm seeing 87% stability locally, up from 51% reported by oss-fuzz. Not sure why it isn't a 100%, can't see anything else in the orphanage that would be non-deterministic.

Copy link
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 15f5a0d

@fanquake fanquake merged commit 40bc501 into bitcoin:master Dec 11, 2023
16 checks passed
Copy link
Member

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK 15f5a0d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants