-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note to msvc readme re building Qt for Bitcoin Core. #29048
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK a9b9fb2, the tip is correct and useful.
However, it won't be needed after migration to CMake as vcpkg's Qt package will be used then.
There is a linter error in CI:
|
Even after I manually checked for whitespace violations on that single line addition :(. Although it does seem like the linter culprit may be elsewhere? Or, am I missing something?
|
Just rewording the linter: The problem is:
The fix is:
(the POSIX environment is assumed) |
We make such changes in a single commit usually :) Mind squashing your commits? |
aaf338e
to
d08e820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d08e820.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d08e820
Updated the msvc readme with a note about avoiding path too long errors when building Qt with Bitcoin Core.
Would have saved me half an hour if I'd remembered this from the last time I did the build.