Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: set m_fallback_fee and m_fee_mode in wallet_fees target #29076

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

brunoerg
Copy link
Contributor

m_fallback_fee and m_fee_mode are used in GetMinimumFeeRate but we're not setting any value for them in wallet_fees target. That's the reason fuzzing is never reaching the following code:

Screenshot 2023-12-13 at 15 04 30

This PR fixes it.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 13, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, murchandamus, achow101
Concept ACK BrandonOdiwuor

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Dec 13, 2023
@maflcko
Copy link
Member

maflcko commented Dec 13, 2023

Could squash this easy change into one commit?

@brunoerg brunoerg force-pushed the 2023-12-fuzz-fees-fallbackfee branch from 3336ebd to e03d6f7 Compare December 13, 2023 21:20
@brunoerg
Copy link
Contributor Author

Could squash this easy change into one commit?

Sure, done!

@maflcko
Copy link
Member

maflcko commented Dec 14, 2023

GHA fail can be ignored:

==> Pouring python@3.11--3.11.6_1.ventura.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'

To force the link and overwrite all conflicting files:
  brew link --overwrite python@3.11

To list all files that would be deleted:
  brew link --overwrite --dry-run python@3.11

Possible conflicting files are:
/usr/local/bin/2to3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/2to3
/usr/local/bin/2to3-3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/2to3-3.11
/usr/local/bin/idle3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/idle3
/usr/local/bin/idle3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/idle3.11
/usr/local/bin/pydoc3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/pydoc3
/usr/local/bin/pydoc3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/pydoc3.11
/usr/local/bin/python3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3
/usr/local/bin/python3-config -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3-config
/usr/local/bin/python3.11 -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3.11
/usr/local/bin/python3.11-config -> /Library/Frameworks/Python.framework/Versions/3.11/bin/python3.11-config
==> /usr/local/Cellar/python@3.11/3.11.6_1/bin/python3.11 -Im ensurepip
==> /usr/local/Cellar/python@3.11/3.11.6_1/bin/python3.11 -Im pip install -v --n
==> Caveats
Python has been installed as
  /usr/local/bin/python3

Unversioned symlinks `python`, `python-config`, `pip` etc. pointing to
`python3`, `python3-config`, `pip3` etc., respectively, have been installed into
  /usr/local/opt/python@3.11/libexec/bin

You can install Python packages with
  pip3 install <package>
They will install into the site-package directory
  /usr/local/lib/python3.11/site-packages

tkinter is no longer included with this formula, but it is available separately:
  brew install python-tk@3.11

gdbm (`dbm.gnu`) is no longer included in this formula, but it is available separately:
  brew install python-gdbm@3.11
`dbm.ndbm` changed database backends in Homebrew Python 3.11.
If you need to read a database from a previous Homebrew Python created via `dbm.ndbm`,
you'll need to read your database using the older version of Homebrew Python and convert to another format.
`dbm` still defaults to `dbm.gnu` when it is installed.

For more information about Homebrew and Python, see: https://docs.brew.sh/Homebrew-and-Python
==> Summary

@maflcko
Copy link
Member

maflcko commented Dec 14, 2023

review ACK e03d6f7

Copy link
Contributor

@BrandonOdiwuor BrandonOdiwuor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Copy link
Contributor

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e03d6f7

Any idea what the CI is upset about?

@DrahtBot DrahtBot requested review from BrandonOdiwuor and removed request for BrandonOdiwuor December 28, 2023 18:16
@maflcko maflcko added this to the 27.0 milestone Dec 29, 2023
@achow101
Copy link
Member

achow101 commented Jan 2, 2024

ACK e03d6f7

@DrahtBot DrahtBot requested review from BrandonOdiwuor and removed request for BrandonOdiwuor January 2, 2024 16:26
@achow101 achow101 merged commit c3038bf into bitcoin:master Jan 2, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants