-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzz: set m_fallback_fee
and m_fee_mode
in wallet_fees
target
#29076
fuzz: set m_fallback_fee
and m_fee_mode
in wallet_fees
target
#29076
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Could squash this easy change into one commit? |
3336ebd
to
e03d6f7
Compare
Sure, done! |
GHA fail can be ignored:
|
review ACK e03d6f7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK e03d6f7
Any idea what the CI is upset about?
ACK e03d6f7 |
m_fallback_fee
andm_fee_mode
are used inGetMinimumFeeRate
but we're not setting any value for them inwallet_fees
target. That's the reason fuzzing is never reaching the following code:This PR fixes it.