tests: Don't depend on value of DEFAULT_PERMIT_BAREMULTISIG

[ajtowns]

Update unit and functional tests so that they continue to work if the default for -permitbaremultisig is changed.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	maflcko, instagibbs, glozow, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #29001 (Ephemeral Anchors by instagibbs)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[maflcko]

elay_fee, std::string& reason);
      |                                                                                                      ^
test/script_p2sh_tests.cpp:29:43: error: argument name 'permit_baremultisig' in comment does not match parameter name 'permit_bare_multisig' [bugprone-argument-comment,-warnings-as-errors]
   29 |            IsStandardTx(tx, std::nullopt, /*permit_baremultisig=*/false, CFeeRate{DUST_RELAY_TX_FEE}, reason);
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                           /*permit_bare_multisig=*/
./policy/policy.h:140:102: note: 'permit_bare_multisig' declared here
  140 | bool IsStandardTx(const CTransaction& tx, const std::optional<unsigned>& max_datacarrier_bytes, bool permit_bare_multisig, const CFeeRate& dust_relay_fee, std::string& reason);
--

[maflcko]

lgtm ACK 7b45744

[instagibbs]

crACK 7b45744

(someone should probably switch it default false and check)

[maflcko]

(someone should probably switch it default false and check)

done with

diff --git a/src/policy/policy.h b/src/policy/policy.h
index 6a7980c312..42359f12a5 100644
--- a/src/policy/policy.h
+++ b/src/policy/policy.h
@@ -36,7 +36,7 @@ static constexpr unsigned int DEFAULT_INCREMENTAL_RELAY_FEE{1000};
 /** Default for -bytespersigop */
 static constexpr unsigned int DEFAULT_BYTES_PER_SIGOP{20};
 /** Default for -permitbaremultisig */
-static constexpr bool DEFAULT_PERMIT_BAREMULTISIG{true};
+static constexpr bool DEFAULT_PERMIT_BAREMULTISIG{0};
 /** The maximum number of witness stack items in a standard P2WSH script */
 static constexpr unsigned int MAX_STANDARD_P2WSH_STACK_ITEMS{100};
 /** The maximum size in bytes of each witness stack item in a standard P2WSH script */

[ajtowns]

crACK 7b45744

(someone should probably switch it default false and check)

see also CI on #29093

[glozow]

ACK 7b45744, changed default locally and all tests passed

[achow101]

ACK 7b45744