ci: Better tidy errors #29094
ci: Better tidy errors #29094
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
maflcko
force-pushed
the
2312-ci-tidy-nice-
branch
from
700468c
to
faec279
Compare
|
🤔 There hasn't been much activity lately and the CI seems to be failing. If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in. |
maflcko
force-pushed
the
2312-ci-tidy-nice-
branch
from
faec279
to
ee64747
Compare
maflcko
force-pushed
the
2312-ci-tidy-nice-
branch
from
ee64747
to
fae70ba
Compare
|
Fixed the bash logic, rebased, and updated OP |
| @@ -182,7 +182,11 @@ if [ "${RUN_TIDY}" = "true" ]; then | |||
|
|
|||
| set -eo pipefail | |||
| cd "${BASE_BUILD_DIR}/bitcoin-$HOST/src/" | |||
| ( run-clang-tidy-"${TIDY_LLVM_V}" -quiet -load="/tidy-build/libbitcoin-tidy.so" "${MAKEJOBS}" ) | grep -C5 "error" | |||
| if ! ( run-clang-tidy-"${TIDY_LLVM_V}" -quiet -load="/tidy-build/libbitcoin-tidy.so" "${MAKEJOBS}" | tee tmp.tidy-out.txt ); then | |||
| grep -C5 "error: " tmp.tidy-out.txt | |||
There was a problem hiding this comment.
Could use grep -B 1 -A 5 instead?
There was a problem hiding this comment.
I think it will always be a guess at the context. I think longer error messages than 5 lines are possible, so if someone needs the full context, they'll have to scroll up either way.
|
rfm? Or does it need more ACKs, or does it need something else? |
Currently tidy errors are not nice, because the user may have to scroll up to see them in a large block of text. See for example (before) https://github.com/bitcoin/bitcoin/runs/19670551485
Fix that by
teeing the output to a file and summarizing the errors in the end again. See for example (after): https://github.com/bitcoin/bitcoin/runs/22647850662