fuzz: set nMaxOutboundLimit in connman target

[brunoerg]

Setting nMaxOutboundLimit (-maxuploadtarget) will make fuzz to reach more coverage in connman target. This value is used in GetMaxOutboundTimeLeftInCycle, OutboundTargetReached and GetOutboundTargetBytesLeft.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	dergoegge, jonatack
Stale ACK	maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #28584 (Fuzz: extend CConnman tests by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[brunoerg]

CI failure is unrelated to this PR.

[maflcko]

lgtm ACK 46d7113

[brunoerg]

friendly ping: @dergoegge

[brunoerg]

Thanks, @dergoegge for your review. Force-pushed addressing: #29172 (comment) and #29172 (comment).

[dergoegge]

utACK e5b9ee0

[jonatack]

ACK e5b9ee0

[achow101]

New compiler warning, using gcc 13.2.1

test/fuzz/connman.cpp: In function ‘void connman_fuzz_target(FuzzBufferType)’:
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vSeedNodes’ [-Werror=missing-field-initializers]
   43 |     connman.Init({ .nMaxOutboundLimit = max_outbound_limit });
      |     ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vWhitelistedRange’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vWhiteBinds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vBinds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::onion_binds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::bind_on_any’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vSeedNodes’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vWhitelistedRange’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vWhiteBinds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::vBinds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::onion_binds’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::bind_on_any’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::m_specified_outgoing’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::m_added_nodes’ [-Werror=missing-field-initializers]
test/fuzz/connman.cpp:43:17: error: missing initializer for member ‘CConnman::Options::m_i2p_accept_incoming’ [-Werror=missing-field-initializers]

[brunoerg]

New compiler warning, using gcc 13.2.1

I'm checking it atm.