refactor: use push_back in TaprootBuilder::Add(), rm NOLINTNEXTLINE and comment #29202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
…nd comment `emplace_back` seems pointless here, as it doesn't avoid a temporary object compared to `push_back`
jonatack
changed the title
jonatack
force-pushed
the
2024-01-rm-unneeded-NOLINTNEXTLINE
branch
from
6c4336a
to
9d4893b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
emplace_backand disabling themodernize-use-emplaceTidy CI check seems pointless here, as IIUC it doesn't avoid a temporary object compared to just usingpush_back. See #28583 for more context.