Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OP_CHECKTEMPLATEVERIFY #29280

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

reardencode
Copy link

This pull request forks from #29198 and only includes the implementation of OP_CHECKTEMPLATEVERIFY, its tests (except the functional ones), and standardization of bare OP_CHECKTEMPLATEVERIFY locking scripts.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 19, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
Concept ACK moonsettler

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #29843 (policy: Allow non-standard scripts with -acceptnonstdtxn=1 (test nets only) by ajtowns)
  • #29270 (Implement OP_CHECKSIGFROMSTACK(VERIFY) by reardencode)
  • #29269 (Add OP_INTERNALKEY for Tapscript by reardencode)
  • #29247 (Reenable OP_CAT by 0xBEEFCAF3)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@moonsettler
Copy link

Concept ACK!

@earonesty
Copy link

Lgtm. It's the simplest and least controversial and has an extremely broad use case set (not perfect for anything but useful for everything). No need to bikeshed if it's the best. It's useful and we need more useful things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants