redeclare nChainTx to use uint64_t

[russeree]

Following up on #29258 the type of nChainTx has now been changed to a uint64_t allowing for the counting of TXs well into the future. The note about changing the type in 2024 was also removed. This passes all extended tests.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #29370 (assumeutxo: Get rid of faked nTx and nChainTx values by ryanofsky)
• #28608 (assumeutxo state and locking cleanup by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[DrahtBot]

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

_{Debug: https://github.com/bitcoin/bitcoin/runs/20917625235}

[dergoegge]

Would you mind adding a test? It should be possible to fake a large nChainTx in a test using assume utxo

[mzumsande]

It should be possible to fake a large nChainTx in a test using assume utxo

It's annoying that each test doing something like that would need to add an entry to the regtest chainparams, maybe my suggestion here to allow that per RPC could make sense (not necessarily in this PR).

[dergoegge]

It's annoying that each test doing something like that would need to add an entry to the regtest chainparams, maybe my suggestion #29261 (comment) to allow that per RPC could make sense (not necessarily in this PR).

I was thinking of a unit test, so no need for an RPC but yes some way to add assumeutxo data for tests would be needed (I assumed we already have this).

[maflcko]

The note about changing the type in 2024 was also removed. This passes all extended tests.

I don't think you need to detail what is changed and if the tests pass in the description. It would be better to focus on information that is useful to reviewers. For example, a measurement of memory before and after.

Also, when changing the type, you'll have to check all places where this is used, and update them, if needed. For example, casts should be removed and other types need to be increased in width to hold the new values.

[maflcko]

Are you still working on this? If not, I am happy to pick up.

[russeree]

Could I please have just a bit more time to work on this?

Thanks, Reese

[fanquake]

@russeree are you still following up here?

[russeree]

@russeree are you still following up here?

I would be willing to hand this off now, primary issue is the inability to allocate the proper amount of time due to other work commitments.

Sorry if this caused any substantial setbacks.

[fanquake]

No worries. @maflcko may pick it up.