Add missed config/bitcoin-config.h header
#29333
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
The `config/bitcoin-config.h` header is required to provide definitions for the `USE_BDB` and `USE_SQLITE` macros.
hebasto
force-pushed
the
240127-config_h
branch
from
6a8a276
to
35ccd50
Compare
| #if defined(HAVE_CONFIG_H) | ||
| #include <config/bitcoin-config.h> | ||
| #endif | ||
|
|
||
| #include <common/system.h> |
There was a problem hiding this comment.
Isn't bitcoin-config.h indirectly included by this system.h include? (which btw, doesn't seems to be needed).
There was a problem hiding this comment.
Isn't
bitcoin-config.hindirectly included by thissystem.hinclude?
It is.
While this header might be included indirectly elsewhere, including it explicitly makes the build process more robust.
There was a problem hiding this comment.
then it would be good to remove the unused include within this change. walletdb.cpp does not call to any system.h` function.
|
What motivates changing only this single file and not the various other modules that iwyu reports to have unused or missing |
It was spotted during debugging another issue. Agree that it looks like a random diff. |
The
config/bitcoin-config.hheader is required to provide definitions for theUSE_BDBandUSE_SQLITEmacros.While this header might be included indirectly elsewhere, including it explicitly makes the build process more robust.