rpc: method removeprunedfunds should take an array of txids

[araujo88]

This PR addresses issue #29466 by updating the removeprunedfunds RPC method to accept an array of transaction IDs (txids). This enhancement allows for batch removal of transactions, improving usability for pruned wallets. The change includes updates to the RPC method signature and the corresponding functional test adjustments to align with the new input format. This feature simplifies wallet management by enabling more efficient transaction handling.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept NACK	luke-jr
Concept ACK	fjahr, BrandonOdiwuor

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

[furszy]

As it breaks RPC compatibility, needs release-notes.

[fjahr]

Concept ACK

[luke-jr]

Probably better to just remain backward compatible, at least for a release or two...?

[araujo88]

Probably better to just remain backward compatible, at least for a release or two...?

It could handle both cases I guess (passing a string as arg and an array of strings).

[luke-jr]

Actually, looking at the implementation deeper, I'm not sure we gain anything from this change. Just use batch RPC calls?

Concept NACK for now.

[araujo88]

Actually, looking at the implementation deeper, I'm not sure we gain anything from this change. Just use batch RPC calls?

Concept NACK for now.

Doing batches of RPC calls is definitely slower than if we handled this case internally. So how is that not a benefit?

[BrandonOdiwuor]

Concept ACK