Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtree: update crc32c subtree #29493

Merged
merged 2 commits into from Feb 28, 2024
Merged

Conversation

fanquake
Copy link
Member

b60d2b7334 Merge bitcoin-core/crc32c-subtree#6: Fix UBSan "misaligned-pointer-use" warning on aarch64
1ac401e32b Fix UBSan "misaligned-pointer-use" warning on aarch64

git-subtree-dir: src/crc32c
git-subtree-split: b60d2b733406cc64025095c6c2cb3933e222b529
@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 27, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto, theuni, dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 359a8d9.

Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 359a8d9

Thanks :)

Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 359a8d9

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64)

File commit ba907f9
(master)
commit 4c12f15
(master and this pull)
SHA256SUMS.part b5eba8a283436c3b... 6014d3fa4f8be6f8...
*-aarch64-linux-gnu-debug.tar.gz 829c712d2b08d013... 7a7153a5a0fce29d...
*-aarch64-linux-gnu.tar.gz 419ac661f51e5b5a... a12a38cc665d4a10...
*-arm-linux-gnueabihf-debug.tar.gz 5663fee152088d6f... 55743c0631a15bf4...
*-arm-linux-gnueabihf.tar.gz 8d4e834d33f08496... cf5cfc37d93b7c68...
*-arm64-apple-darwin-unsigned.tar.gz 2b74ac81b62642f4... 42bfc2605bdf6d5c...
*-arm64-apple-darwin-unsigned.zip 3c4e78caeed83315... 3531417a72395582...
*-arm64-apple-darwin.tar.gz 876a77dd6de31080... c4b60438e0cdf687...
*-powerpc64-linux-gnu-debug.tar.gz 46ea102b47db3905... 305a03dc0b1d1ccc...
*-powerpc64-linux-gnu.tar.gz 2b3b9a798d909d80... 04a631fbcdc1e3ee...
*-powerpc64le-linux-gnu-debug.tar.gz b0c8e866e7f17f23... 9b4002aff4e4eddb...
*-powerpc64le-linux-gnu.tar.gz 9fa3773087c6550e... 4ce6ddf765710a2c...
*-riscv64-linux-gnu-debug.tar.gz 344064b382c4c6cc... 5450534e3d37235a...
*-riscv64-linux-gnu.tar.gz 870c4ffefb4eeb78... 1518d6b30e06f9ea...
*-x86_64-apple-darwin-unsigned.tar.gz 94d1d92ffd669c37... 7acb6c8ab528e547...
*-x86_64-apple-darwin-unsigned.zip 735ada59d43cbc8d... be2158f92725655a...
*-x86_64-apple-darwin.tar.gz dc837a3576093024... b56f197f441c5aaa...
*-x86_64-linux-gnu-debug.tar.gz f6cc9e3e9a625706... ab7b2ba978490eb0...
*-x86_64-linux-gnu.tar.gz 365e71ff601e95fa... 6094d4261e48d070...
*.tar.gz 43ffebf97a4c5fc5... fa0552e56a65caba...
guix_build.log b98357662408e8ef... 31a470d6933b7964...
guix_build.log.diff 3de41002fef3032d...

@theuni
Copy link
Member

theuni commented Feb 28, 2024

c-i failure appears unrelated.

@fanquake fanquake merged commit d752831 into bitcoin:master Feb 28, 2024
15 of 16 checks passed
@fanquake fanquake deleted the update_crc32_subtree branch February 28, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ubsan: misaligned-pointer-use in crc32c/src/crc32c_arm64.cc
5 participants