Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: add target for local address stuff #29495

Closed
wants to merge 1 commit into from

Conversation

brunoerg
Copy link
Contributor

This PR adds fuzz target for local address functions - (AddLocal, RemoveLocal, SeenLocal, IsLocal)

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 27, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK dergoegge, vasild

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Feb 27, 2024
src/test/fuzz/net.cpp Outdated Show resolved Hide resolved
src/test/fuzz/net.cpp Outdated Show resolved Hide resolved
src/test/fuzz/net.cpp Show resolved Hide resolved
@brunoerg
Copy link
Contributor Author

Force-pushed addressing:
#29495 (comment)
#29495 (comment)
#29495 (comment)

Thanks, @dergoegge

src/test/fuzz/net.cpp Outdated Show resolved Hide resolved
@brunoerg
Copy link
Contributor Author

Force-pushed addressing #29495 (comment)

Copy link
Contributor

@vasild vasild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fe4e38c

src/test/fuzz/net.cpp Outdated Show resolved Hide resolved
@brunoerg
Copy link
Contributor Author

Force-pushed addressing #29495 (comment). Thanks, @vasild.

Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 25eab52

@DrahtBot DrahtBot requested a review from vasild February 29, 2024 17:20
Copy link
Contributor

@vasild vasild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 25eab52

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 1, 2024

🐙 This pull request conflicts with the target branch and needs rebase.

@fanquake
Copy link
Member

fanquake commented Mar 1, 2024

This has been merged.

@fanquake fanquake closed this Mar 1, 2024
fanquake added a commit to bitcoin-core/gui that referenced this pull request Mar 1, 2024
25eab52 fuzz: add target for local addresses (brunoerg)

Pull request description:

  This PR adds fuzz target for local address functions - (`AddLocal`, `RemoveLocal`, `SeenLocal`, `IsLocal`)

ACKs for top commit:
  dergoegge:
    ACK 25eab52
  vasild:
    ACK 25eab52

Tree-SHA512: 24faaab86dcd8835ba0e2d81fb6322a39a9266c7edf66415dbc4421754054f47efb6e0de4efdc7ea026b0686792658e86a526f7cf27cbc6cf9ed0c4aed376f97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants