Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: modify weight estimate in functional tests #29502

Merged
merged 2 commits into from
Mar 5, 2024
Merged

test: modify weight estimate in functional tests #29502

merged 2 commits into from
Mar 5, 2024

Commits on Mar 1, 2024

  1. test: fix weight estimates in functional tests 

    Updates the weight estimate to be more accurate by removing byte buffers and calculating the length of the count of scriptWitnesses rather than just using the count itself.
    @m3dwards
    m3dwards committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3c49e69 View commit details
    Browse the repository at this point in the history

  2. test: fix flaky wallet_send functional test 

    Rather than asserting that the exact fees are the same, check the fee rate rounded to nearest interger. This will account for small differences in fees caused by variability in ECDSA signature lengths.
    @m3dwards
    m3dwards committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e67ab17 View commit details
    Browse the repository at this point in the history