Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: Misc improvements for lint runner #29537

Merged
merged 3 commits into from Mar 18, 2024
Merged

lint: Misc improvements for lint runner #29537

merged 3 commits into from Mar 18, 2024

Conversation

fjahr
Copy link
Contributor

@fjahr fjahr commented Mar 2, 2024

  1. Document the dependency to rust being installed locally
  2. Add the build output directory to gitignore
  3. Clean up the build output directory when running make clean

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 2, 2024 •
edited

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, TheCharlatan
Stale ACK ismaelsadeeq

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Mar 2, 2024
TheCharlatan
TheCharlatan reviewed Mar 6, 2024
View reviewed changes
Makefile.am Outdated Show resolved Hide resolved
maflcko
maflcko reviewed Mar 11, 2024
View reviewed changes
test/lint/README.md Outdated Show resolved Hide resolved
ismaelsadeeq
ismaelsadeeq approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@ismaelsadeeq ismaelsadeeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3d44a26

maflcko
maflcko reviewed Mar 11, 2024
View reviewed changes
test/lint/README.md Outdated Show resolved Hide resolved
maflcko
maflcko approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

test/lint/README.md Outdated Show resolved Hide resolved
@fjahr
Copy link
Contributor Author

fjahr commented Mar 17, 2024

Rebased to give the CI a chance to show green and took the suggested rewording from @maflcko .

@maflcko
Copy link
Member

maflcko commented Mar 18, 2024

ACK 742d2b9

TheCharlatan
TheCharlatan approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 742d2b9

@fanquake fanquake merged commit f1a19d7 into bitcoin:master Mar 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maflcko maflcko maflcko approved these changes

@TheCharlatan TheCharlatan TheCharlatan approved these changes

@ismaelsadeeq ismaelsadeeq Awaiting requested review from ismaelsadeeq

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fjahr @DrahtBot @maflcko @TheCharlatan @ismaelsadeeq @fanquake