Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation: Use witness maleation flag for non-segwit blocks #29540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

validation: Use witness maleation flag for non-segwit blocks #29540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/validation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3744,9 +3744,9 @@ static bool CheckMerkleRoot(const CBlock& block, BlockValidationState& state)
* first transaction needs to have at least one input. */
static bool CheckWitnessMalleation(const CBlock& block, bool expect_witness_commitment, BlockValidationState& state)
{
if (expect_witness_commitment) {
if (block.m_checked_witness_commitment) return true;
if (block.m_checked_witness_commitment) return true;

if (expect_witness_commitment) {
int commitpos = GetWitnessCommitmentIndex(block);
if (commitpos != NO_WITNESS_COMMITMENT) {
assert(!block.vtx.empty() && !block.vtx[0]->vin.empty());
Expand Down Expand Up @@ -3787,6 +3787,7 @@ static bool CheckWitnessMalleation(const CBlock& block, bool expect_witness_comm
}
}

block.m_checked_witness_commitment = true;
return true;
}

Expand Down