test: remove file-wide interpreter.cpp ubsan suppression

[fanquake]

No description provided.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, Sjors, dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #29543 (refactor: Avoid unsigned integer overflow in script/interpreter.cpp by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[hebasto]

ACK 217c0ce.

However, I'd prefer an alternative approach.

[Sjors]

Is it possible to mark suppressions inside the source code itself? In that case we could specifically suppress the two affected lines. That has the benefit of not having to touch the code itself (like #29543 does), while avoiding future regressions elsewhere in EvalScript.

utACK 217c0ce

[Sjors]

I assume stacktop / altstacktop don't work here?

[fanquake]

Not in this context, because these are runtime suppressions.

[fanquake]

Is it possible to mark suppressions inside the source code itself?

There are various ways to suppress issues, however, in this PR, I'm not interested in changing the src, just reducing the scope of the currently applied runtime suppression.

[dergoegge]

ACK 217c0ce

[fanquake]

I'm going to merge this to reduce the scope of the suppression, discussion around refactoring / inlining suppressions could can in #29543.