Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: chainparams updates for 27.x #29547

Merged
merged 3 commits into from Mar 5, 2024

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Mar 4, 2024

Update chainparams pre 27.x branch off.

Note: Remember that some variance is expected in the m_assumed_* sizes.

@fanquake fanquake added this to the 27.0 milestone Mar 4, 2024
@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 4, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK Sjors, glozow, instagibbs

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #29198 (OP_CHECKTEMPLATEVERIFY, OP_CHECKSIGFROMSTACK(VERIFY), OP_INTERNALKEY validation (LNHANCE) by reardencode)
  • #27433 (getblocktemplate improvements for segwit and sigops by Sjors)
  • #26201 (Remove Taproot activation height by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@Sjors
Copy link
Member

Sjors commented Mar 4, 2024

ACK d9f30b0

Copy link
Member

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d9f30b0 (checked mainnet locally, checked testnet/signet on block explorers and sanity checked the numbers)

Copy link
Member

@instagibbs instagibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d9f30b0

only checked mainnet params locally

@fanquake fanquake merged commit 11a1db8 into bitcoin:master Mar 5, 2024
16 checks passed
@fanquake fanquake deleted the kernel_assume_valid_pre_27_x branch March 5, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants