fix: avoid calling GetCoin
and SignTransaction()
inside of assert(...)
in tests
#29572
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, it's not possible to compile without assertions at the moment because of this check. However, if it would be removed one day then
txpackage_tests
will start to fail for such builds.Running
txpackage_tests
compiled with the check removed andCPPFLAGS="-DNDEBUG"
:master:
*** 21 failures are detected in the test module "Bitcoin Core Test Suite"
this PR:
*** No errors detected