Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make BITCOIN_QT_PATH_PROGS always check $PATH before failure #29653

Closed
wants to merge 1 commit into from
Closed

build: make BITCOIN_QT_PATH_PROGS always check $PATH before failure #29653

wants to merge 1 commit into from

Commits on Mar 14, 2024

  1. build: make BITCOIN_QT_PATH_PROGS always check $PATH before failure 

    `BITCOIN_QT_PATH_PROGS` should conform to it's documentation for parameter `$3`:
> dnl Inputs: $3: Look for $2 here before $PATH

Prior to the change, when `$3` was specified, the function would *not* check `$PATH`. Fixing this resolves the case where the `lrelease`, `lupdate` and `lconvert` binaries live in a different directory than the other QT Base binaries, hindering `./configure` from detecting them. The issue was observed on Nix(OS) which has different binary folders for `nixpkgs.qt5.qtbase` and `nixpkgs.qt5.qttools`, causing `./configure` to not allow building `bitcoin-qt`.
    @cbergqvist
    cbergqvist committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7da77ee View commit details
    Browse the repository at this point in the history