ci: Bump TIDY_LLVM_V

[hebasto]

This PR switches to the latest IWYU 0.22, which is compatible with Clang 18.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake
Stale ACK	maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #28710 (Remove the legacy wallet and BDB dependency by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[maflcko]

Please remove the unused src/script/signingprovider.cpp: // NOLINTNEXTLINE(modernize-use-emplace)

[fanquake]

This PR switches to the latest IWYU 0.22

Where is this change? Forgot we turned this into a one-liner.

[maflcko]

Thanks!

lgtm ACK af2cd8e

[hebasto]

This PR switches to the latest IWYU 0.22

Where is this change?

The IWYU branch being built is clang_"${TIDY_LLVM_V}":

bitcoin/ci/test/01_base_install.sh

Line 70 in af2cd8e

${CI_RETRY_EXE} git clone --depth=1 https://github.com/include-what-you-use/include-what-you-use -b clang_"${TIDY_LLVM_V}" /include-what-you-use

[fanquake]

CI is failing:

clang-tidy-18 -p=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/script/miniscript.cpp
./script/interpreter.h:28:1: error: enum '(unnamed enum at ./script/interpreter.h:28:1)' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   28 | enum
      | ^
./script/interpreter.h:190:12: error: enum 'SigVersion' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
  190 | enum class SigVersion
      |            ^
./script/interpreter.h:274:12: error: enum 'MissingDataBehavior' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
  274 | enum class MissingDataBehavior
      |            ^
./script/miniscript.h:194:12: error: enum 'Fragment' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
  194 | enum class Fragment {
      |            ^
./script/miniscript.h:228:12: error: enum 'Availability' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
  228 | enum class Availability {
      |            ^
./script/miniscript.h:234:12: error: enum 'MiniscriptContext' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
  234 | enum class MiniscriptContext {
      |            ^
./script/miniscript.h:1663:12: error: enum 'ParseContext' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
 1663 | enum class ParseContext {
      |            ^
./script/miniscript.h:2152:12: error: enum 'DecodeContext' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
 2152 | enum class DecodeContext {
      |            ^
./script/script.h:72:6: error: enum 'opcodetype' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   72 | enum opcodetype
      |      ^
./script/script_error.h:11:14: error: enum 'ScriptError_t' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   11 | typedef enum ScriptError_t
      |              ^
./script/solver.h:22:12: error: enum 'TxoutType' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   22 | enum class TxoutType {

[fanquake]

ACK 636c986