Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Drop --enable-c++20 option #29669

Merged
merged 1 commit into from Mar 18, 2024
Merged

ci: Drop --enable-c++20 option #29669

merged 1 commit into from Mar 18, 2024

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Mar 17, 2024

This option has ceased to exist since #28349.

This option has ceased to exist since bitcoin#28349.
@hebasto hebasto added the Tests label Mar 17, 2024
@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 17, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #28710 (Remove the legacy wallet and BDB dependency by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko
Copy link
Member

maflcko commented Mar 18, 2024

I kept it, so that it can be turned into an c++23 option once there is cmake, but it is fine to remove the no-op in the meantime.

ACK 64722e4

@fanquake
Copy link
Member

This will all have to be rewritten in any case, so fine to dump it.

@fanquake fanquake merged commit 9a459e3 into bitcoin:master Mar 18, 2024
16 checks passed
@hebasto hebasto deleted the 240317-ci branch March 18, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants