Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Bump msan to llvm-18 #29676

Merged
merged 1 commit into from
Mar 20, 2024
Merged

ci: Bump msan to llvm-18 #29676

merged 1 commit into from
Mar 20, 2024

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Mar 19, 2024

Last one: #28476

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 19, 2024 •
edited

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Mar 19, 2024
@fanquake
Copy link
Member

Is there a workaround for llvm/llvm-project#79620 ? I had branch to do the same bump, but it was blocked on at least this issue. We will also need to account for this, depending on the kernel version: llvm/llvm-project#78354.

@DrahtBot
Copy link
Contributor

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

Debug: https://github.com/bitcoin/bitcoin/runs/22825353269

@maflcko
Copy link
Member Author

maflcko commented Mar 19, 2024

Looks like this also fixes the outstanding msan fuzz CI issue?

@fanquake
Copy link
Member

Appears to be the case. MSAN fuzz is running for me on x86_64

fanquake
fanquake approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faecf3a - There is now a 18.1.2, but given it doesn't fix the instrumenting in libunwind, we don't need that here. I've tested that both jobs are now working on both arches.

@fanquake fanquake merged commit 5b9831a into bitcoin:master Mar 20, 2024
16 checks passed
@fanquake fanquake mentioned this pull request Mar 20, 2024
Closed
@maflcko maflcko deleted the 2403-ci-msan-18- branch March 20, 2024 12:01
@fanquake
Copy link
Member

Also kicked https://cirrus-ci.com/task/6539451837448192 in qa-assets for a look.

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Mar 21, 2024
@fanquake
ci: Bump msan to llvm-18
f824d65 
Github-Pull: bitcoin#29676
Rebased-From: faecf3a
@fanquake fanquake mentioned this pull request Mar 21, 2024
Merged
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Mar 21, 2024
@fanquake
ci: Bump msan to llvm-18
a7116c8 
Github-Pull: bitcoin#29676
Rebased-From: faecf3a
fanquake added a commit that referenced this pull request Mar 26, 2024
@fanquake
Merge #29693: [27.x] Further Backports
b3cd952 
a7116c8 ci: Bump msan to llvm-18 (MarcoFalke)
05f69b3 ci, macos: Use `--break-system-packages` with Homebrew's python (Hennadii Stepanov)
603f036 ci: Add workaround for Homebrew's python link error (Hennadii Stepanov)
5d381cf serfloat: improve/simplify tests (Pieter Wuille)
f4be4d7 serfloat: do not test encode(bits)=bits anymore (Pieter Wuille)

Pull request description:

  Currently:
  * #29192
  * #29610
  * #29676

ACKs for top commit:
  stickies-v:
    ACK a7116c8 - all clean test backports

Tree-SHA512: f3508a2c20d336c8647ba16886859d6a070584c4739fc8b5cfce2041a0662794775fb0ce89c9bf848a29e70089bae05ad1c921bbe45afe3fd5cac2a5c6b76baf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanquake fanquake fanquake approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maflcko @DrahtBot @fanquake