Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in expat.mk. #29698

Closed
wants to merge 1 commit into from
Closed

Conversation

RoboSchmied
Copy link
Contributor

Fix one typo.

This will help every developer who hates typos.

Fix one typo.
@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 21, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@maflcko
Copy link
Member

maflcko commented Mar 22, 2024

Also:

src/validation.cpp:5785: neccessary ==> necessary
src/validation.h:278: evalution ==> evaluation, evolution

https://cirrus-ci.com/task/4940678185091072?logs=lint#L739

@RoboSchmied
Copy link
Contributor Author

RoboSchmied commented Mar 22, 2024

Also:

src/validation.cpp:5785: neccessary ==> necessary
src/validation.h:278: evalution ==> evaluation, evolution

https://cirrus-ci.com/task/4940678185091072?logs=lint#L739

Thank you.
I can not fork the bitcoin repo now because I have a fork of dash

  • which github selected (magically) as the source of this (web gui pencil) commit
  • that prevents me of forking the bitcoin repo.

And your mentioned typos are not included in dash.

May I close this and open a new pull request with all 3 typo fixed directly on the bitcoin repo?

Sorry, this never happened to me before.

@maflcko
Copy link
Member

maflcko commented Mar 24, 2024

May I close this and open a new pull request with all 3 typo fixed directly on the bitcoin repo?

It is possible to fetch any commit with git. It is also possible to rewrite any branch to any commit in git. Finally, it is also possible to (force) push any branch to GitHub, to possibly overwrite an existing branch. But up to you, if you want to close this pull request.

@fanquake
Copy link
Member

Cherry-picked this into #29738.

@fanquake fanquake closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants