test: make p2p_handshake robust against timeoffset warnings #29704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test requires that limited nodes are not peered with when the node's system time exceeds ~ 24h of the node's chaintip timestamp, as per PeerManagerImpl::GetDesirableServiceFlags. By patching this test to modify the timestamp of the chaintip as opposed to mocking the node's system time, we make it resilient to future commits where the node raises a warning if it detects its system time is too much out of sync with its outbound peers. See bitcoin#29623
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
lgtm ACK 032a597 A third alternative might be to restart the node after each test to drop the state, but that seems fragile. |
|
Please don't |
theStack
approved these changes
Mar 22, 2024
brunoerg
approved these changes
Mar 22, 2024
BrandonOdiwuor
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
p2p_handshaketest requires that limited nodes are not peered with when the node's system time exceeds ~ 24h of the node's chaintip timestamp, as perPeerManagerImpl::GetDesirableServiceFlags.By patching this test to modify the timestamp of the chaintip as opposed to mocking the node's system time, we make it resilient to future commits where the node raises a warning if it detects its system time is too much out of sync with its outbound peers.
Resolves a silent merge conflict in #29623, that is changing the warning behaviour when significant time differences with outbound peers are detected, failing the test as it's currently in master.
Considerations/alternatives I've thought of:
self.setup_clean_chain = Truetoself.set_test_params(), to avoid creating a new tip with a (much) older date, but it doesn't seem to matter?setmocktimealtogether and instead usecreate_blockinstead, but that seems like it'll be a lot more verbose and I don't think it's worth it?Big thanks to theStack for his time in discussing this with me offline.