28950 followups

[instagibbs]

Follow-ups to #28950

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	glozow, stickies-v

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

[glozow]

LGTM. Did you want to take #28950 (comment)?

[instagibbs]

@glozow punting on that one, thanks

[DrahtBot]

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

_{Debug: https://github.com/bitcoin/bitcoin/runs/23054231617}

[fanquake]

test/txpackage_tests.cpp:821:103: error: argument name 'client_maxfeerate' in comment does not match parameter name 'client_max_feerate' [bugprone-argument-comment,-warnings-as-errors]
  821 |                                                           package_rich_parent, /*test_accept=*/false, /*client_maxfeerate=*/{});
      |                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~
      |                                                                                                       /*client_max_feerate=*/

[stickies-v]

Approach ACK cc2a4a6. First commit should probably be a scripted-diff though, and I think the last 2 commits make more sense when squashed?

LGTM. Did you want to take #28950 (comment)?

I think that's fine to leave as is, as per #28950 (comment)

[instagibbs]

First commit should probably be a scripted-diff though, and I think the last 2 commits make more sense when squashed?

both done, thanks

[glozow]

utACK 7b29119

[stickies-v]

ACK 7b29119