build, macos: Drop unused osx_volname target
#29733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Mar 31, 2024
984c548 fixup! cmake: Migrate Guix build scripts to CMake (Hennadii Stepanov) fb23c32 fixup! cmake: Add `Maintenance` module (Hennadii Stepanov) 6ac45b7 refactor! cmake: Redefine/adjust per-configuration flags (Hennadii Stepanov) bce7bea fixup! build: Generate `share/toolchain.cmake` in depends (Hennadii Stepanov) Pull request description: What to test: 1. `cmake --build build && cmake --build build -t deploydir` and the following `cmake --build build -t deploy` when cross-compiling for macOS and on macOS natively. 2. Guix builds. This PR includes changes from bitcoin#29733. UPD. Also related: bitcoin#29761. ACKs for top commit: TheCharlatan: ACK 984c548 Tree-SHA512: be056492ee7f5f210afaef7574bdcc56f01be80e7db888b7571e36a4be50f90337d0f9f1a623588f8c91898665ff06b22300dec9292016f05f2d2913a823d2eb
|
ACK eff19fa |
|
tACK eff19fa Tested that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
osx_volnamemakefile target was introduced in #7192 and was used to pass the package name to Gitian scripts as a content of theosx_volnamefile.With the current Guix scripts, the
osx_volnamefile is never read. Therefore, its creation might be omitted.My Guix builds: