RPC: createrawtransactions gains 'fee' pseudo-address for fee safety

[jgarzik]

Suggested by gmaxwell.

[gavinandresen]

I needed this for the 'smartfee' work I'm doing; I made it a CTransaction method in core.cpp, though:

/** Amount of bitcoins spent by the transaction.
    @return sum of all outputs (note: does not include fees)
 */
int64 CTransaction::GetValueOut() const
{
    int64 nValueOut = 0;
    BOOST_FOREACH(const CTxOut& txout, this->vout)
    {
        nValueOut += txout.nValue;
        if (!MoneyRange(txout.nValue) || !MoneyRange(nValueOut))
            throw std::runtime_error("GetValueOut() : value out of range");
    }
    return nValueOut;
}

[jgarzik]

Note that @gmaxwell was unable to get this PR to work for him, so there is a bug in there somewher.

@gavinandresen CTransaction method works

[jgarzik]

Rebased... though the current IRC consensus seems to lean towards another RPC 'buildrawtransaction' which has fee and coin selection smarts.

[BitcoinPullTester]

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/be96bf0a577faf928376e62840cd1ea33e5fbd16 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

[jgarzik]

Closing. A good idea, but buggy, and should be superceded by 'buildrawtransaction' which is smarter about fees and coin selection in general.