ci: Drop duplicated compiler flags

[hebasto]

On the master branch @ 0d509ba, it is easy to check the "Options used to compile and link" section in the configure script output and observe duplicated compiler flags.

This PR cleans such cases up.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	maflcko, fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #29790 ([DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system -- WIP by hebasto)
• #29742 ([WIP] ci: test secp256k1 MSAN asm annotations by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[maflcko]

lgtm ACK be97652

The depends ones are not needed, because depends already passes the flags through. The -g isn't needed, because it is always set by default.

[fanquake]

I guess going forward, we'll have to remember to never add any logic/other flags to the --with-sanitizers/cmake equivalent option, that differ from just setting -fsanitize=x? Otherwise they could possibly get missed in CI.

Removing this also now skips the link check(s) and I don't see where flags are getting added to LDFLAGS elsewhere? So this is at least a change in behaviour, some (not duplicated) flags have been dropped entirely, and I'd say somewhat less clear.

[hebasto]

The --with-sanitizers=memory has been restored in the recent push.

[maflcko]

re-ACK a3485af

[fanquake]

ACK a3485af - no-longer a change in behaviour.