Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Some test/fuzz/test_runner.py improvements #29821

Merged
merged 2 commits into from Apr 9, 2024

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 6, 2024

These changes are split from #29774 and can be beneficial on their own.

The new BITCOINFUZZ environment variable complements the already existing set of variables used by tests:

binaries = {
"bitcoind": ("bitcoind", "BITCOIND"),
"bitcoin-cli": ("bitcoincli", "BITCOINCLI"),
"bitcoin-util": ("bitcoinutil", "BITCOINUTIL"),
"bitcoin-wallet": ("bitcoinwallet", "BITCOINWALLET"),
}

The `BITCOINFUZZ` environment variable allows to override the default
path to the fuzz binary.

It complements the already existing set of variables used by tests:
 - BITCOIND
 - BITCOINCLI
 - BITCOINUTIL
 - BITCOINWALLET
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 6, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, davidgumberg

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Apr 6, 2024
@hebasto
Copy link
Member Author

hebasto commented Apr 6, 2024

cc @maflcko @dergoegge

@maflcko
Copy link
Member

maflcko commented Apr 7, 2024

lgtm ACK 47cedee

@davidgumberg
Copy link
Contributor

davidgumberg commented Apr 7, 2024

utACK 47cedee

CI Failure appears unrelated

@fanquake fanquake merged commit f348ec7 into bitcoin:master Apr 9, 2024
15 of 16 checks passed
@hebasto hebasto deleted the 240406-fuzz-runner branch April 9, 2024 13:18
Pttn added a commit to RiecoinTeam/Riecoin that referenced this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants