minisketch: update subtree to 3472e2f5ec75ace39ce9243af6b3fee233a67492 #29823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the Possibly this is due to a silent merge conflict (the changes in this pull request being Leave a comment here, if you need help tracking down a confusing failure. |
fanquake
force-pushed
the
pull_minisketch_tree
branch
2 times, most recently
from
2161196
to
c03fd4e
Compare
|
Fuzzed for 2000 CPU hours, no more UB was found |
dergoegge
approved these changes
Apr 10, 2024
fanquake
force-pushed
the
pull_minisketch_tree
branch
from
c03fd4e
to
89be2df
Compare
fanquake
changed the title
fanquake
force-pushed
the
pull_minisketch_tree
branch
2 times, most recently
from
396873b
to
d66eefc
Compare
fanquake
changed the title
|
sipa/minisketch#81 is now merged upstream. |
3472e2f5ec Merge sipa/minisketch#81: Avoid overflowing shift by special casing inverse of 1 653d8b2e26 Avoid overflowing shift by special casing inverse of 1 33b7c200b9 Merge sipa/minisketch#80: Add c++20 version of CountBits 4a48f31a37 Merge sipa/minisketch#83: ci: Fix "s390x (big-endian)" task 82b6488acb Add c++20 version of CountBits 0498084d31 ci: Fix "s390x (big-endian)" task 71709dca9e Merge sipa/minisketch#82: ci: Fix `x86_64-w64-mingw32` task 9e6127fa98 Merge sipa/minisketch#74: Avoid >> above type width in BitWriter ed420bc170 ci: Fix `x86_64-w64-mingw32` task fe1040f227 Drop -Wno-shift-count-overflow compile flag 154bcd43bd Avoid >> above type width in BitWriter 67b87acdb6 Merge sipa/minisketch#78: ci: Update macOS image for CI 7de7250416 ci: Update macOS image for CI 83d812ea9f Merge sipa/minisketch#73: ci: Use correct variable to designate C++ compiler e051a7d690 ci: Install wine32 package for Windows tests 2d2c695d78 build: Drop unused `CC` variable 1810fcbd11 ci: Use correct variable to designate C++ compiler 022b959049 Merge sipa/minisketch#77: Add missing include 08443c4892 Add missing include git-subtree-dir: src/minisketch git-subtree-split: 3472e2f5ec75ace39ce9243af6b3fee233a67492
fanquake
changed the title
fanquake
force-pushed
the
pull_minisketch_tree
branch
from
d66eefc
to
4722b7c
Compare
This is now ready for review. |
dergoegge
approved these changes
Apr 12, 2024
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Apr 18, 2024
Backport changes from bitcoin#29823.
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Apr 18, 2024
Backport changes from bitcoin#29823.
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Apr 18, 2024
fd71331 fixup! cmake: Build `minisketch` static library (Hennadii Stepanov) 49a902a fixup! cmake: Check system symbols (Hennadii Stepanov) Pull request description: Backport changes from bitcoin#29823. ACKs for top commit: theuni: utACK fd71331 Tree-SHA512: 5259b9c7aa1f4466846c2974aa2a73b5bc507da9c53ac574e6ee6ca1a0c16502e1cde87d0a4119f32b44a5b7fe672ba3919da3b949eff5f9beac736695e89a61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sipa/minisketch#81 will fix #29799.
Minor build cleanups after sipa/minisketch#80.