Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet, tests: Avoid stringop-overflow warning in PollutePubKey #30131

Merged
merged 1 commit into from
May 22, 2024
Merged

wallet, tests: Avoid stringop-overflow warning in PollutePubKey #30131

merged 1 commit into from
May 22, 2024
+4 −2

Conversation

achow101
Copy link
Member

Fixes #30114

@DrahtBot
Copy link
Contributor

DrahtBot commented May 17, 2024 •
edited

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK theStack, laanwj, maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@achow101 achow101 force-pushed the fix-pollutpubkey-stringop-overflow branch from dd18fe6 to 2289d45 Compare May 21, 2024 16:59
theStack
theStack approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2289d45

laanwj
laanwj approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@laanwj laanwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2289d45

@maflcko
Copy link
Member

maflcko commented May 22, 2024

ACK 2289d45 with g++ 14.1.1 🦄

Show signature

Signature:

untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: ACK 2289d4524053ab71c0d9133987cb36412797c1a2 with g++ 14.1.1 🦄
TjtmKQsXUYiFgTCuw6z0Tax+TbeKHJD9b3u0Dnwie7qSiCyzVNoZlQqwcXbzDua+DyPjZF++qIzEMC11iFEDCQ==

@fanquake fanquake merged commit 93bec6e into bitcoin:master May 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theStack theStack theStack approved these changes

@laanwj laanwj laanwj approved these changes

Assignees
No one assigned
Labels
Tests Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stringop-overflow warning with GCC 14
6 participants
@achow101 @DrahtBot @maflcko @theStack @laanwj @fanquake