-
Notifications
You must be signed in to change notification settings - Fork 35.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Correct pull request prefix for scripts and tools #30150
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK fa3e115
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK fa3e115
I'm half tempted to bikeshed this to using tools
, but this also seems totally fine to me :)
The bot will understand it, so you are free to use it. :) Edit: But I haven't seen anyone use it yet, so updating the docs can be done as a follow-up when people are using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK fa3e115.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK fa3e115
script
is confusing, because in the context of Bitcoin, it usually means Bitcoin script (c.f.CScript
inscript.h
, or pull requests such as #27122 using the prefix).This could be fixed by renaming it to
scripts
(with a plurals
at the end), however, looking at the current usagecontrib
andcli
seem more common (#29687, #26953, #26584, #24864, #30074, #29433 ...)