Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Correct pull request prefix for scripts and tools #30150

Merged
merged 1 commit into from
May 22, 2024

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented May 22, 2024

script is confusing, because in the context of Bitcoin, it usually means Bitcoin script (c.f. CScript in script.h, or pull requests such as #27122 using the prefix).

This could be fixed by renaming it to scripts (with a plural s at the end), however, looking at the current usage contrib and cli seem more common (#29687, #26953, #26584, #24864, #30074, #29433 ...)

@DrahtBot
Copy link
Contributor

DrahtBot commented May 22, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake, willcl-ark, hebasto, theuni

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa3e115

Copy link
Member

@willcl-ark willcl-ark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa3e115

I'm half tempted to bikeshed this to using tools, but this also seems totally fine to me :)

@maflcko
Copy link
Member Author

maflcko commented May 22, 2024

I'm half tempted to bikeshed this to using tools, but this also seems totally fine to me :)

The bot will understand it, so you are free to use it. :)

Edit: But I haven't seen anyone use it yet, so updating the docs can be done as a follow-up when people are using tools.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa3e115.

Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa3e115

@fanquake fanquake merged commit 6f36624 into bitcoin:master May 22, 2024
16 checks passed
@maflcko maflcko deleted the 2405-doc-doc branch May 22, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants