Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depends: Fetch miniupnpc sources from an alternative website #30151

Merged
merged 1 commit into from
May 23, 2024
Merged

depends: Fetch miniupnpc sources from an alternative website #30151

merged 1 commit into from
May 23, 2024

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented May 22, 2024 •
edited

The https://miniupnp.tuxfamily.org website is unavailable now.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 22, 2024 •
edited

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK achow101, theuni

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@fanquake
Copy link
Member

website is unavailable now.

Forever? Temporarily? Why not use the other official site?

Also no mention that this is now downloading a bunch of other stuff that we don't use?

@hebasto
Copy link
Member Author

hebasto commented May 22, 2024

website is unavailable now.

Forever?

I don't know.

Temporarily?

I don't know.

Why not use the other official site?

Which one? http://miniupnp.free.fr without HTTPS?

Also no mention that this is now downloading a bunch of other stuff that we don't use?

Mentioned in the PR description.

@laanwj
Copy link
Member

laanwj commented May 22, 2024

Which one? http://miniupnp.free.fr/ without HTTPS?

If that does keep the sha256 hash the same then maybe. Mind that github-generated tar.gzs aren't guaranteed to have a stable hash.

@hebasto hebasto changed the title depends: Fetch miniupnpc sources from GitHub depends: Fetch miniupnpc sources from an alternative website May 22, 2024
@hebasto
Copy link
Member Author

hebasto commented May 22, 2024

Which one? http://miniupnp.free.fr/ without HTTPS?

If that does keep the sha256 hash the same then maybe.

It does. Switched to that website.

@laanwj
Copy link
Member

laanwj commented May 22, 2024

It does. Switched to that website.

Thanks. Agree it's really suboptimal to use http because of protocol-level mischief, though. i hope tuxfamily will be back.

@hebasto hebasto mentioned this pull request May 22, 2024
Merged
hebasto added a commit to hebasto/bitcoin that referenced this pull request May 22, 2024
@hebasto
Merge #209: cmake, ci: Skip miniupnpc package in depends
bae096a 
384b44e cmake, ci: Skip `miniupnpc` package in depends (Hennadii Stepanov)

Pull request description:

  This change fixes CI jobs as the `miniupnpc` source archive is not available neither at https://miniupnp.tuxfamily.org nor at https://bitcoincore.org/depends-sources at this moment.

  It could be reverted back after bitcoin#30151 or uploading  the source archive to the https://bitcoincore.org.

Top commit has no ACKs.

Tree-SHA512: 0f19072501493aa2625992c06b127aba61cdadf1caff39277af0ab8446981fe852490d2949e6a5995e00a1b6f23f970bb7e933f2cc4d6c7f7ae62da05feb0608
@achow101
Copy link
Member

ACK 21b8a14

The main page of tuxfamily.org has 2 posts stating that they've had weeks of downtime in the past 6 months, so I think it makes sense to switch to a different mirror as they seem to be having issues. It's unfortunate that miniupnp.free.fr is http only, but we check the hash so I think it's fine.

theuni
theuni approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @laanwj and @achow101.

This is unfortunate, but seems like the best solution for now. The checksum should point out any hijinks.

utACK 21b8a14

@edilmedeiros
Copy link
Contributor

edilmedeiros commented May 22, 2024 •
edited

utACK 21b8a14

Which one? http://miniupnp.free.fr/ without HTTPS?

If that does keep the sha256 hash the same then maybe.

It does. Switched to that website.

This is the same URL I used to update the MacOS package in the macports project a couple of months ago, so there will be more people watching it.

@fanquake fanquake merged commit ef44726 into bitcoin:master May 23, 2024
16 checks passed
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request May 23, 2024
@hebasto @fanquake
depends: Fetch miniupnpc sources from an alternative website
77b2321 
The https://miniupnp.tuxfamily.org website is unavailable now.

Github-Pull: bitcoin#30151
Rebased-From: 21b8a14
@fanquake fanquake mentioned this pull request May 23, 2024
Merged
@fanquake
Copy link
Member

Backported to 27.x in #30092.

@hebasto hebasto deleted the 240522-upnp-dl branch May 23, 2024 09:39
fanquake added a commit that referenced this pull request May 29, 2024
@fanquake
Merge #30092: [27.x] Backports and rc1
fccd32e 
22701a4 doc: update manual pages for 27.1rc1 (fanquake)
9e91907 build: bump version to 27.1rc1 (fanquake)
9b4640c doc: update release-notes.md for 27.1 (fanquake)
80032d6 qt: 27.1rc1 translations update (Hennadii Stepanov)
423bd6d windeploy: Renew certificate (Ava Chow)
77b2321 depends: Fetch miniupnpc sources from an alternative website (Hennadii Stepanov)
31adcfa test: add GetAddedNodeInfo() CJDNS regression unit test (Jon Atack)
9cdb9ed p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo() (Jon Atack)
3c26058 crypto: disable asan for sha256_sse4 with clang and -O0 (Cory Fields)
0ba11cf rpc: move UniValue in blockToJSON (willcl-ark)
dedf319 gui: don't permit port in proxy IP option (willcl-ark)
d1289a1 gui: fix create unsigned transaction fee bump (furszy)

Pull request description:

  Backports:
  * bitcoin-core/gui#812
  * bitcoin-core/gui#813
  * #30085
  * #30094
  * #30097
  * #30149
  * #30151

  Bump to 27.1rc1.

ACKs for top commit:
  stickies-v:
    re-ACK 22701a4
  willcl-ark:
    reACK 22701a4
  hebasto:
    re-ACK 22701a4.

Tree-SHA512: 6eca44ba7e6664eb4677646597dfdaf56a241c8c3e95e0ab8929ee2fc3671303fc6c2634d359b4523dbd452ac5e54fd1f4c7c2bf7e9c5209395f8cb3b4753fb3
glozow pushed a commit to glozow/bitcoin that referenced this pull request Jun 10, 2024
@hebasto @glozow
depends: Fetch miniupnpc sources from an alternative website
7b2489f 
The https://miniupnp.tuxfamily.org website is unavailable now.

Rebased-From: 21b8a14
Github-Pull: bitcoin#30151
@glozow glozow mentioned this pull request Jun 10, 2024
Merged
@glozow
Copy link
Member

glozow commented Jun 10, 2024

backported to 26.x in #30260

glozow added a commit that referenced this pull request Jun 12, 2024
@glozow
Merge #30260: [26.x] backports and final changes for 26.2rc1
d10cf12 
7ca424f [doc] update release notes for 26.2rc1 (glozow)
03a91a0 [doc] manpages for 26.2rc1 (glozow)
4c824bb [build] bump to version 26.2rc1 (glozow)
b992297 qt: 26.2rc1 translations update (Hennadii Stepanov)
7b2489f depends: Fetch miniupnpc sources from an alternative website (Hennadii Stepanov)

Pull request description:

  Backports + release notes for:
  - #30151

  And final changes for 26.2rc1:
  - build changes
  - manpages
  - non-removal translations updates

ACKs for top commit:
  stickies-v:
    ACK 7ca424f
  fanquake:
    ACK 7ca424f

Tree-SHA512: 881697eb6fb78261e3deb5064d6f38227b449049add810c7da999a1f22fad60b9dd32057c626bbfaa7e461d53635cd2f7a9fb225eba0f6fb503afd4f1ef6c46d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theuni theuni theuni approved these changes

Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@hebasto @DrahtBot @fanquake @laanwj @achow101 @edilmedeiros @glozow @theuni