-
Notifications
You must be signed in to change notification settings - Fork 35.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting MinGW multithreading bugfix to makefile.mingw #3121
Conversation
Original fix: https://github.com/bitcoin/bitcoin/commit /8864019f6d88b13d3442843d9e6ebeb8dd938831
Automatic sanity-testing: FAILED MERGE, see http://jenkins.bluematt.me/pull-tester/d2078c63193c6105e60e56c1e7a7adc3aed31edd for test log. This pull does not merge cleanly onto current master |
The makefile buildsystem has since been replaced by autotools in git master. Does autotools do this right, or do we need an equivalent fix there? |
@theuni Can you take a look? |
I suppose this is useful for @luke-jr for his stable branch. As for the autotools build system this change is not needed. mingwthrd is detected and -D_MT is added: |
yes, autotools should be handling this correctly already. |
Note that I could not find any testers for native win32+autotools. @phelixbtc If you'd be willing to be a guinea pig, I'm happy to get it working there. |
I'll try my very best. Should I start out with current master? |
Yes. Are you available to hop on freenode for a realtime hack-a-thon? |
@theuni: tried to email you... contact me at blockchained.com I assume this will not go into 0.8.5 then... |
0.8.5 is already released weeks ago. It'll probably be in 0.8.6, but that may be after 0.9.0 |
Closing; makefile.mingw is no more. |
Original fix:
8864019