Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting MinGW multithreading bugfix to makefile.mingw #3121

Closed
wants to merge 1 commit into from

Conversation

phelixbtc
Copy link

Original fix:
8864019

@BitcoinPullTester
Copy link

Automatic sanity-testing: FAILED MERGE, see http://jenkins.bluematt.me/pull-tester/d2078c63193c6105e60e56c1e7a7adc3aed31edd for test log.

This pull does not merge cleanly onto current master
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@sipa
Copy link
Member

sipa commented Oct 21, 2013

The makefile buildsystem has since been replaced by autotools in git master. Does autotools do this right, or do we need an equivalent fix there?

@Diapolo
Copy link

Diapolo commented Oct 22, 2013

@theuni Can you take a look?

@laanwj
Copy link
Member

laanwj commented Oct 22, 2013

I suppose this is useful for @luke-jr for his stable branch.

As for the autotools build system this change is not needed. mingwthrd is detected and -D_MT is added:
https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L194

@theuni
Copy link
Member

theuni commented Oct 22, 2013

yes, autotools should be handling this correctly already.

@theuni
Copy link
Member

theuni commented Oct 22, 2013

Note that I could not find any testers for native win32+autotools. @phelixbtc If you'd be willing to be a guinea pig, I'm happy to get it working there.

@phelixbtc
Copy link
Author

I'll try my very best. Should I start out with current master?

@theuni
Copy link
Member

theuni commented Oct 24, 2013

Yes. Are you available to hop on freenode for a realtime hack-a-thon?

@phelixbtc
Copy link
Author

@theuni: tried to email you... contact me at blockchained.com

I assume this will not go into 0.8.5 then...

@luke-jr
Copy link
Member

luke-jr commented Oct 27, 2013

0.8.5 is already released weeks ago. It'll probably be in 0.8.6, but that may be after 0.9.0

@gavinandresen
Copy link
Contributor

Closing; makefile.mingw is no more.

Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Apr 8, 2020
Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Apr 8, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants