Update guiutil.cpp #3486
Closed
Update guiutil.cpp #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix old bug with tooltip.startsWith("<qt>") and HtmlEscape issue...
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d3c6a89b54278fce83969f70d344d488aff188af for binaries and test log. |
|
What issue does this fix? |
| @@ -361,11 +361,11 @@ bool ToolTipToRichTextFilter::eventFilter(QObject *obj, QEvent *evt) | |||
| { | |||
| QWidget *widget = static_cast<QWidget*>(obj); | |||
| QString tooltip = widget->toolTip(); | |||
| if(tooltip.size() > size_threshold && !tooltip.startsWith("<qt/>") && !Qt::mightBeRichText(tooltip)) | |||
| if(tooltip.size() > size_threshold && !tooltip.startsWith("<qt>") && !tooltip.startsWith("<qt/>") && !Qt::mightBeRichText(tooltip)) | |||
There was a problem hiding this comment.
Could be abbreviated to
if(tooltip.size() > size_threshold && !tooltip.startsWith("<qt") && !Qt::mightBeRichText(tooltip))
There was a problem hiding this comment.
Indeed, it would be the most correct option.
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Feb 12, 2014
Alternative implementation. Thanks to @awoland for the original. Fixes bitcoin#3486.
pooler
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Mar 26, 2014
Alternative implementation. Thanks to @awoland for the original. Fixes bitcoin#3486. Rebased-from: 90a2868 0.8.x
wtogami
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Mar 27, 2014
Alternative implementation. Thanks to @awoland for the original. Fixes bitcoin#3486. Rebased-from: 90a2868 0.8.x
wtogami
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Apr 4, 2014
Alternative implementation. Thanks to @awoland for the original. Fixes bitcoin#3486. Rebased-from: 90a2868 0.8.x
MathyV
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
May 9, 2014
Alternative implementation. Thanks to @awoland for the original. Fixes bitcoin#3486. Rebased-from: 90a2868 0.8.x
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Dec 18, 2018
Alternative implementation. Thanks to @awoland for the original. Fixes bitcoin#3486.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix old bug with tooltip.startsWith("") and HtmlEscape issue...