CKeyStore::AddKey must return a boolean #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should have been fixed before indeed, it's only fixed in Matt's encryption branch (newenc) now. Also, it's not a problem as CKeyStore::AddKey() is masked by CWallet::AddKey(), which ignores the other one's result. If we weren't in -rc3 already, I'd ACK. |
|
pulled wallet crypto, so, superceded |
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
Aug 16, 2016
7a49cac Merge bitcoin#410: Add string.h include to ecmult_impl 0bbd5d4 Add string.h include to ecmult_impl c5b32e1 Merge bitcoin#405: Make secp256k1_fe_sqrt constant time 926836a Make secp256k1_fe_sqrt constant time e2a8e92 Merge bitcoin#404: Replace 3M + 4S doubling formula with 2M + 5S one 8ec49d8 Add note about 2M + 5S doubling formula 5a91bd7 Merge bitcoin#400: A couple minor cleanups ac01378 build: add -DSECP256K1_BUILD to benchmark_internal build flags a6c6f99 Remove a bunch of unused stdlib #includes 65285a6 Merge bitcoin#403: configure: add flag to disable OpenSSL tests a9b2a5d configure: add flag to disable OpenSSL tests b340123 Merge bitcoin#402: Add support for testing quadratic residues e6e9805 Add function for testing quadratic residue field/group elements. efd953a Add Jacobi symbol test via GMP fa36a0d Merge bitcoin#401: ecmult_const: unify endomorphism and non-endomorphism skew cases c6191fd ecmult_const: unify endomorphism and non-endomorphism skew cases 0b3e618 Merge bitcoin#378: .gitignore build-aux cleanup 6042217 Merge bitcoin#384: JNI: align shared files copyright/comments to bitcoinj's 24ad20f Merge bitcoin#399: build: verify that the native compiler works for static precomp b3be852 Merge bitcoin#398: Test whether ECDH and Schnorr are enabled for JNI aa0b1fd build: verify that the native compiler works for static precomp eee808d Test whether ECDH and Schnorr are enabled for JNI 7b0fb18 Merge bitcoin#366: ARM assembly implementation of field_10x26 inner (rebase of bitcoin#173) 001f176 ARM assembly implementation of field_10x26 inner 0172be9 Merge bitcoin#397: Small fixes for sha256 3f8b78e Fix undefs in hash_impl.h 2ab4695 Fix state size in sha256 struct 6875b01 Merge bitcoin#386: Add some missing `VERIFY_CHECK(ctx != NULL)` 2c52b5d Merge bitcoin#389: Cast pointers through uintptr_t under JNI 43097a4 Merge bitcoin#390: Update bitcoin-core GitHub links 31c9c12 Merge bitcoin#391: JNI: Only call ecdsa_verify if its inputs parsed correctly 1cb2302 Merge bitcoin#392: Add testcase which hits additional branch in secp256k1_scalar_sqr d2ee340 Merge #388: bench_ecdh: fix call to secp256k1_context_create 093a497 Add testcase which hits additional branch in secp256k1_scalar_sqr a40c701 JNI: Only call ecdsa_verify if its inputs parsed correctly faa2a11 Update bitcoin-core GitHub links 47b9e78 Cast pointers through uintptr_t under JNI f36f9c6 bench_ecdh: fix call to secp256k1_context_create bcc4881 Add some missing `VERIFY_CHECK(ctx != NULL)` for functions that use `ARG_CHECK` 6ceea2c align shared files copyright/comments to bitcoinj's 70141a8 Update .gitignore 7b549b1 Merge bitcoin#373: build: fix x86_64 asm detection for some compilers bc7c93c Merge bitcoin#374: Add note about y=0 being possible on one of the sextic twists e457018 Merge bitcoin#364: JNI rebased 86e2d07 JNI library: cleanup, removed unimplemented code 3093576 JNI library bd2895f Merge pull request bitcoin#371 e72e93a Add note about y=0 being possible on one of the sextic twists 3f8fdfb build: fix x86_64 asm detection for some compilers e5a9047 [Trivial] Remove double semicolons c18b869 Merge pull request bitcoin#360 3026daa Merge pull request bitcoin#302 03d4611 Add sage verification script for the group laws a965937 Merge pull request bitcoin#361 83221ec Add experimental features to configure 5d4c5a3 Prevent damage_array in the signature test from going out of bounds. 419bf7f Merge pull request bitcoin#356 03d84a4 Benchmark against OpenSSL verification git-subtree-dir: src/secp256k1 git-subtree-split: 7a49cac
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 13, 2016
8225239 Merge bitcoin#433: Make the libcrypto detection fail the newer API. 12de863 Make the libcrypto detection fail the newer API. 2928420 Merge bitcoin#427: Remove Schnorr from travis as well 8eecc4a Remove Schnorr from travis as well a8abae7 Merge bitcoin#310: Add exhaustive test for group functions on a low-order subgroup b4ceedf Add exhaustive test for verification 83836a9 Add exhaustive tests for group arithmetic, signing, and ecmult on a small group 20b8877 Add exhaustive test for group functions on a low-order subgroup 80773a6 Merge bitcoin#425: Remove Schnorr experiment e06e878 Remove Schnorr experiment 04c8ef3 Merge bitcoin#407: Modify parameter order of internal functions to match API parameter order 6e06696 Merge bitcoin#411: Remove guarantees about memcmp-ability 40c8d7e Merge bitcoin#421: Update scalar_4x64_impl.h a922365 Merge bitcoin#422: Restructure nonce clearing 3769783 Restructure nonce clearing 0f9e69d Restructure nonce clearing 9d67afa Update scalar_4x64_impl.h 7d15cd7 Merge bitcoin#413: fix auto-enabled static precompuatation 00c5d2e fix auto-enabled static precompuatation 91219a1 Remove guarantees about memcmp-ability 7a49cac Merge bitcoin#410: Add string.h include to ecmult_impl 0bbd5d4 Add string.h include to ecmult_impl 353c1bf Fix secp256k1_ge_set_table_gej_var parameter order 541b783 Fix secp256k1_ge_set_all_gej_var parameter order 7d893f4 Fix secp256k1_fe_inv_all_var parameter order c5b32e1 Merge bitcoin#405: Make secp256k1_fe_sqrt constant time 926836a Make secp256k1_fe_sqrt constant time e2a8e92 Merge bitcoin#404: Replace 3M + 4S doubling formula with 2M + 5S one 8ec49d8 Add note about 2M + 5S doubling formula 5a91bd7 Merge bitcoin#400: A couple minor cleanups ac01378 build: add -DSECP256K1_BUILD to benchmark_internal build flags a6c6f99 Remove a bunch of unused stdlib #includes 65285a6 Merge bitcoin#403: configure: add flag to disable OpenSSL tests a9b2a5d configure: add flag to disable OpenSSL tests b340123 Merge bitcoin#402: Add support for testing quadratic residues e6e9805 Add function for testing quadratic residue field/group elements. efd953a Add Jacobi symbol test via GMP fa36a0d Merge bitcoin#401: ecmult_const: unify endomorphism and non-endomorphism skew cases c6191fd ecmult_const: unify endomorphism and non-endomorphism skew cases 0b3e618 Merge bitcoin#378: .gitignore build-aux cleanup 6042217 Merge bitcoin#384: JNI: align shared files copyright/comments to bitcoinj's 24ad20f Merge bitcoin#399: build: verify that the native compiler works for static precomp b3be852 Merge bitcoin#398: Test whether ECDH and Schnorr are enabled for JNI aa0b1fd build: verify that the native compiler works for static precomp eee808d Test whether ECDH and Schnorr are enabled for JNI 7b0fb18 Merge bitcoin#366: ARM assembly implementation of field_10x26 inner (rebase of bitcoin#173) 001f176 ARM assembly implementation of field_10x26 inner 0172be9 Merge bitcoin#397: Small fixes for sha256 3f8b78e Fix undefs in hash_impl.h 2ab4695 Fix state size in sha256 struct 6875b01 Merge bitcoin#386: Add some missing `VERIFY_CHECK(ctx != NULL)` 2c52b5d Merge bitcoin#389: Cast pointers through uintptr_t under JNI 43097a4 Merge bitcoin#390: Update bitcoin-core GitHub links 31c9c12 Merge bitcoin#391: JNI: Only call ecdsa_verify if its inputs parsed correctly 1cb2302 Merge bitcoin#392: Add testcase which hits additional branch in secp256k1_scalar_sqr d2ee340 Merge #388: bench_ecdh: fix call to secp256k1_context_create 093a497 Add testcase which hits additional branch in secp256k1_scalar_sqr a40c701 JNI: Only call ecdsa_verify if its inputs parsed correctly faa2a11 Update bitcoin-core GitHub links 47b9e78 Cast pointers through uintptr_t under JNI f36f9c6 bench_ecdh: fix call to secp256k1_context_create bcc4881 Add some missing `VERIFY_CHECK(ctx != NULL)` for functions that use `ARG_CHECK` 6ceea2c align shared files copyright/comments to bitcoinj's 70141a8 Update .gitignore 7b549b1 Merge bitcoin#373: build: fix x86_64 asm detection for some compilers bc7c93c Merge bitcoin#374: Add note about y=0 being possible on one of the sextic twists e457018 Merge bitcoin#364: JNI rebased 86e2d07 JNI library: cleanup, removed unimplemented code 3093576 JNI library bd2895f Merge pull request bitcoin#371 e72e93a Add note about y=0 being possible on one of the sextic twists 3f8fdfb build: fix x86_64 asm detection for some compilers e5a9047 [Trivial] Remove double semicolons c18b869 Merge pull request bitcoin#360 3026daa Merge pull request bitcoin#302 03d4611 Add sage verification script for the group laws a965937 Merge pull request bitcoin#361 83221ec Add experimental features to configure 5d4c5a3 Prevent damage_array in the signature test from going out of bounds. 419bf7f Merge pull request bitcoin#356 03d84a4 Benchmark against OpenSSL verification git-subtree-dir: src/secp256k1 git-subtree-split: 8225239
deadalnix
pushed a commit
to deadalnix/bitcoin
that referenced
this pull request
Jan 19, 2017
47b9e78 Cast pointers through uintptr_t under JNI (Jon Griffiths)
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 16, 2019
user-friendly launcher for testnet mode
rajarshimaitra
pushed a commit
to rajarshimaitra/bitcoin
that referenced
this pull request
Aug 5, 2021
Glossary - Private Channel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function should return true in case of success, currently returns nothing. This trivial patch fixes that.