New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed alert system from main.cpp #506
Conversation
Even though it no longer triggers RPC safe mode there is some concern that it could still be misused. Signed-off-by: David Perry <enmaku@gmail.com>
There is concern by who? I strongly believe that the ability to broadcast a message in case of emergency is important; before removing it, generate some consensus on the bitcoin-dev mailing list that removing it is a good idea (I'll argue against). |
I was simply going off the comments on the Bitcoin StackExchange. I believe the primary concern was that it could be used for spam/DoS. I'll gladly submit the idea to the mailing list for consensus. |
I believe this is in reference to http://bitcoin.stackexchange.com/questions/740/how-can-the-alert-system-be-triggered-who-can-do-it and http://bitcoin.stackexchange.com/questions/636/is-the-alert-system-still-in-the-main-clients-code-will-it-be-removed I'm not really for removing it, but there's always the Git history if we want to revive and improve it to be more decentralized down the road. |
That's correct Alex. There's a discussion on the Bitcoin-Dev mailing list if you've got input to add: http://sourceforge.net/mailarchive/forum.php?thread_name=CAOPxoMv7EGwgBNuvYpaD_4LtyxUUCvQ2Pe0DCZO4uHoAoMyfnA%40mail.gmail.com&forum_name=bitcoin-development |
It seems that public opinion is that the code should remain for the time being. Closing this request until there are additional commits or more support in the mailing list/forums. |
Fair enough. Sounds like there's some good discussion about the alert system at least so I don't consider my time to have been wasted bringing it up :) |
[Release] thintimer backport
…presentation ec0a7b3 Don't touch leading zeros in wnaf_fixed. (Jonas Nick) 9e36d1b Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar. (Jonas Nick) 96f68a0 Don't invert scalar in wnaf_fixed when it is even because a caller might intentionally give a scalar with many leading zeros. (Jonas Nick) 6dbb007 Increase sparsity of pippenger fixed window naf representation (Jonas Nick) Pull request description: Fixes bitcoin#506 Tree-SHA512: 49a237a7d09c0c376ba4e6b1f522b9aff2517e420dfef9df810fd5ba920e0b98be8fe3f730b32e41b4aef475bc4cf3b13220024bd8d6f40c2744e6f392ff97a8
…-#503 fix unlock wallet issue
path-finding: rephrased sentence
Even though it no longer triggers RPC safe mode there is some concern that it could still be misused.
Signed-off-by: David Perry enmaku@gmail.com