Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept any sequence of PUSHDATAs in OP_RETURN outputs #5079

Closed
wants to merge 3 commits into from
Closed

Accept any sequence of PUSHDATAs in OP_RETURN outputs #5079

wants to merge 3 commits into from

Commits on Nov 13, 2014

  1. Make TX_SCRIPTHASH clear vSolutionsRet first 

    Previously unlike other transaction types the TX_SCRIPTHASH would not
clear vSolutionsRet, which means that unlike other transaction types if
it was called twice in a row you would get the result of the previous
invocation as well.
    @petertodd
    petertodd committed Nov 13, 2014
    Configuration menu
    Copy the full SHA
    19c0afa View commit details
    Browse the repository at this point in the history

  2. Add IsPushOnly(const_iterator pc) 

    Allows IsPushOnly() to be applied to just part of the script for
OP_RETURN outputs.
    @petertodd
    petertodd committed Nov 13, 2014
    Configuration menu
    Copy the full SHA
    04a6275 View commit details
    Browse the repository at this point in the history

  3. Accept any sequence of PUSHDATAs in OP_RETURN outputs 

    Previously only one PUSHDATA was allowed, needlessly limiting
applications such as matching OP_RETURN contents with bloom filters that
operate on a per-PUSHDATA level. Now any combination that passes
IsPushOnly() is allowed, so long as the total size of the scriptPubKey
is less than 42 bytes. (unchanged modulo non-minimal PUSHDATA encodings)

Also, this fixes the odd bug where previously the PUSHDATA could be
replaced by any single opcode, even sigops consuming opcodes such as
CHECKMULTISIG. (20 sigops!)
    @petertodd
    petertodd committed Nov 13, 2014
    Configuration menu
    Copy the full SHA
    c263701 View commit details
    Browse the repository at this point in the history